mrmaffen / auto-open-anything

Auto Open Anything is a WoW addon that automatically opens all containers directly after looting them
GNU General Public License v3.0
1 stars 2 forks source link

Tainting with 118697 #4

Open tflo opened 2 years ago

tflo commented 2 years ago

I had to deactivate 118697 (“Big Bag of Pet Supplies”) because it repeatedly triggered a taint error.

Thanks for this very handy addon! Besides that one container, it works flawlessly.

– Tom

Edit: 184866 (“Grummlepouch”) also produces taint. Edit II: Also 122535 (“Traveler’s Pet Supplies”)

tflo commented 2 years ago

PS:

I just noticed that apparently I have to disable the container on each of my 16 toons separately! So, it is faster to batch-edit the SavedVariables files with my text editor. But then I don’t need an in-game GUI at all.

Please make the settings global, and not per-char. It was already fancy to have to disable the minimap button 16 times, but this is a bit too much now 🤕

tflo commented 2 years ago

PS II:

Here a quick fix for the SavedVariables issue:

Main.lua

Line 36:

Change

local defaults = {
    char = {}
}

to

local defaults = {
    profile = {}
}

Line 39:

Change

defaults.char[dbVersion] = {

to

defaults.profile[dbVersion] = {

and then search-replace all db.char[ with db.profile[ throughout the whole file.


This works because you already have assigned the "Default" profile to every char (see the profileKeys table in the SavedVar file). You just haven’t used it.

Later on, in the case you introduce a setting where you think it absolutely has to be char-specific, you can still allow the user to set a specific profile for a char. This will then be registered in the profileKeys table (instead of "Default"). – Or you use char for that particular setting.