search

mrman511 / event-manager-ruby

0 stars 0 forks source link

created todo controller for fetch (multiple and single) and create #25

Closed mrman511 closed 2 weeks ago

mrman511 commented 3 weeks ago

Issue: https://github.com/mrman511/event-manager-ruby/issues/22

Todo Controller Routes

fulrich commented 2 weeks ago

I know there are a lot of comments here. But overall this was really good.

I have notes around a few Rails thing (active record weirdness TBH). And just improving the tests a bit. Otherwise I think you can fix this up real quick and it will be 👍

mrman511 commented 2 weeks ago

I know there are a lot of comments here. But overall this was really good.

  • Small concise PR
  • Every newly introduced method was tested
  • Every new method was clean. Did a single thing and nothing else.

I have notes around a few Rails thing (active record weirdness TBH). And just improving the tests a bit. Otherwise I think you can fix this up real quick and it will be 👍

This is great honestly the more messages the better. I appreciate all the insight, I am definitely learning a lot.