mrmans0n / compose-rules

Lint rules for ktlint/detekt aimed to contribute to a healthier usage of Compose. Actively maintained and evolved fork of the Twitter Compose rules.
https://mrmans0n.github.io/compose-rules
Other
543 stars 20 forks source link

Check for Scope Functions in ViewModel Forwarding Rule #210

Closed t-regbs closed 4 months ago

t-regbs commented 5 months ago

This covers the case of forwarding within scope functions, addressing #117.

t-regbs commented 4 months ago

Thanks for the contribution!

I've left some comments of things that would need addressing before merging. Biggest one is that you'll need to cap the surface checked by your new scope changes to minimize false positives.

Thanks for pointing that out, I have made changes to cap the scope function check and addressed your other comments