search

mrmans0n / compose-rules

Lint rules for ktlint/detekt aimed to contribute to a healthier usage of Compose. Actively maintained and evolved fork of the Twitter Compose rules.
https://mrmans0n.github.io/compose-rules
Other
525 stars 19 forks source link

Consider honoring `ComposableNaming` in ktlint rules #291

Closed Goooler closed 2 weeks ago

Goooler commented 2 weeks ago

ComposableNaming is from Android Lint rules but it's not honored in this ktlint ruleset.

Similar case in ktlint side like https://github.com/pinterest/ktlint/issues/2612.

mrmans0n commented 2 weeks ago

That's odd, it should be explicitly ignoring things annotated by that suppression: https://github.com/mrmans0n/compose-rules/blob/main/rules/common/src/main/kotlin/io/nlopez/compose/rules/Naming.kt

Where did you observe this?

Goooler commented 2 weeks ago

Oooops, my bad! The real issue should be #290.