search

mrmans0n / smart-location-lib

Android library project that lets you manage the location updates to be as painless as possible
1.65k stars 353 forks source link

RxJava 1 vs 2 #195

Closed KennyGoers closed 7 years ago

KennyGoers commented 7 years ago

Could you support or at least call out you are RxJava 2? Cost me much confusion as to why things that should be compatible were not.

mrmans0n commented 7 years ago

In the README for v 3.3.1 it says "The wrappers to rxjava2 are located in this package", so it's in there. I'll make it more prominent in the future, to avoid confusion.

If you want rxjava 1 support, you could use the v3.2.11 of the library. It doesn't need the extra dependency, only the :library one is enough.

KennyGoers commented 7 years ago

Thanks for the clarification, maybe an RxJava 1 vs 2 section that calls out the library for us that are stuck on 1 for a while. I read right over the rxjava2 reference you mentioned, thats on me.

mrmans0n commented 7 years ago

Yeah, maybe it'll be a good idea to create a new dependency to add rxjava1 support. Thanks for the idea :D