search

mrmans0n / smart-location-lib

Android library project that lets you manage the location updates to be as painless as possible
1.65k stars 352 forks source link

Settings dialog is not showing! #237

Open khaledkhj opened 6 years ago

khaledkhj commented 6 years ago

Thanks for the great work on this library!

There still this issue here, the settings dialog is not showing if the GPS is OFF! I am not sure if it is related to Android OS version!

Anyway, Android OS is 8.0.0

here is my code provider = new LocationGooglePlayServicesProvider(); provider.setCheckLocationSettings(true); provider.setLocationSettingsAlwaysShow(true); provider.init(this, LoggerFactory.buildLogger(true));

Thank you.

jatin-lakhani commented 6 years ago

+1 Having the same issue. Any solution will greatly be appreciated!

RazibKani commented 5 years ago

Basically you can not show Location Settings if not init SmartLocation using Activity Context, because the Dialog only show if context is instance of Activity as shown below..

if (context instanceof Activity) { try { // Show the dialog by calling startResolutionForResult(), and check the result // in onActivityResult(). status.startResolutionForResult((Activity) context, REQUEST_CHECK_SETTINGS); } catch (IntentSender.SendIntentException e) { logger.i("PendingIntent unable to execute request."); } } else { logger.w("Provided context is not the context of an activity, therefore we can't launch the resolution activity."); }

This snippet from https://github.com/mrmans0n/smart-location-lib/blob/master/library/src/main/java/io/nlopez/smartlocation/location/providers/LocationGooglePlayServicesProvider.java