search

mrmap-community / GeoPortal.rlp

Other
7 stars 2 forks source link

Search Results show NO IMAGE on random occasions #15

Closed SvenTUM closed 2 years ago

SvenTUM commented 2 years ago

Describe the bug

When searching for WMS or WMC the search results are missing some of the extent images.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a GeoPortal e.g. GeoPortal.rlp
  2. Start a search
  3. Open some WMS or WMC searches
  4. See NO IMAGE graphic in place of the extent image.

Expected behavior

The extent should be shown with the configured base map in the background.

Screenshots

Screenshot 2021-10-22 133013

SvenTUM commented 2 years ago

My guess is , that this is due to to high response times and could likely be fixed by caching the images.

holsandre commented 2 years ago

its not random, if you look closely you'll see it always happens on all sublayers after the first one and its because the function which generates these extent images is faulty, its this one:

https://github.com/mrmap-community/GeoPortal.rlp/blob/master/searchCatalogue/utils/viewHelper.py#L462-L482

i made a non recursive function of this, i dont think recursion is needed here because we always know the length of the list(number of sublayers), not sure why this one is recursive

i already pushed it to this branch, going to merge it tomorrow it think. https://github.com/mrmap-community/GeoPortal.rlp/tree/15_no_extent_images

holsandre commented 2 years ago

fixed in https://github.com/mrmap-community/GeoPortal.rlp/pull/16