search

mrmap-community / Mapbender2.8

Other
3 stars 1 forks source link

mobilemap2 - ol6 implementation #59

Closed karlbrink closed 3 years ago

karlbrink commented 3 years ago

first draft from Sebastian Pauli commited under https://git.osgeo.org/gitea/Pauli/Mapbender2.8/commit/a1596e9b2122342b6bbae45197b108b84ff0242c

i will commit an adoption for testing soon

karlbrink commented 3 years ago

i pushed the changes to our prototype in my opinion its working as aspected. if someone pls could doublecheck - after this: PR and Merge.

SvenTUM commented 3 years ago

I'll merge it as well next week.

SvenTUM commented 3 years ago

Looks good to me!

I merged it and will include it in the next update.

karlbrink commented 3 years ago

sooo, pls doublecheck again - featureInfo for loaded services (loaded with the integrated search of the mobileclient) is not working after the update

SvenTUM commented 3 years ago

sooo, pls doublecheck again - featureInfo for loaded services (loaded with the integrated search of the mobileclient) is not working after the update

You're right. It won't work. I just reverted the commit.

The method getGetFeatureInfoUrl is still used (for the Info request), but is not defined any more. The proposed commit cannot be merged.

karlbrink commented 3 years ago

easy fix from stackoverflow https://stackoverflow.com/questions/63591303/openlayers-wms-getgetfeatureinfourl-is-not-a-function: use the new ol6 method getFeatureInfoUrl located in mapbender/http/extensions/mobilemap2/scripts/netgis/map.js#1001 var url = mapLayer.getSource().getFeatureInfoUrl

karlbrink commented 3 years ago

should be tested also: https://documents.geoportal.rlp.de//mediawiki/index.php/Mobilemap2#Neu_November_2019

sebastianpauli commented 3 years ago

Hi,

meanwhile the getFeatureInfo call has also been changed in my osgeo repo: f65dfeb169.

Best regards