search

mrmckeb / typescript-plugin-css-modules

A TypeScript language service plugin providing support for CSS Modules.
MIT License
1.32k stars 74 forks source link

Add support for Node.js Subpath Imports #263

Open in-in opened 7 months ago

in-in commented 7 months ago

Is your feature request related to a problem? Please describe. I tried using Subpath imports but they don't work. It would be great if it were possible to use native way no configure paths.

Describe the solution you'd like Subpath imports should work the same way as aliases from tsconfig.json work now.

Describe alternatives you've considered I don't know any alternatives for Subpath imports

Additional context Article: https://betterprogramming.pub/the-native-way-to-configure-path-aliases-in-frontend-projects-5db70f19a6e0 Docs: https://nodejs.org/api/packages.html#subpath-imports

Now the plugin works in two cases: relative path import styles from "../styles/Home.module.css";

24086110815

alias from tsconfig.json import styles from "@/styles/Home.module.css";

24086111007

But if you use subpath imports you get an error: import styles from "#styles/Home.module.css";

24086111142

stefan-dasbach-lumi commented 2 months ago

Can we get an update on this @mrmckeb?

Guihgo commented 1 month ago

not working with libraries installed at node_modules too.

npm install foo_bar_library import style from "foo_bar_library/style.module.css"

mrmckeb commented 1 month ago

Hi all, this seems like a fairly simple thing to implement. We should probably look at supporting "exports" too at some stage.

Is anyone interested in creating a PR to support this? If not, I can probably make time in the next week or two.

mrmckeb commented 1 month ago

@Guihgo I think you have a different issue. Can you please raise a new issue with a reproduction? This plugin definitely works with installed packages, and we have tests covering that.