mrmelon54 / armored-elytra-fabric

Shows the elytra and armor when using the armored elytra datapack
12 stars 5 forks source link

Original chestplate show when using CIT Resewn with custom textures #15

Closed mrmelon54 closed 1 year ago

Julienraptor01 commented 2 years ago

I was about to report this issue but apparently you are already aware of it. I just let you a comment to say thank you for this mod and be notified when you fix it. ❤️

mrmelon54 commented 2 years ago

@Julienraptor01 important question: what mod are you using for CIT

Julienraptor01 commented 2 years ago

@Julienraptor01 important question: what mod are you using for CIT

CIT Resewn as it's the one compatible with OptiFine format. I didn't tried Chime because it would mean i need to change the format of my CIT.

mattyalanestock commented 1 year ago

From what I could test, using CIT Resewn, the chestplate texture becomes completely dependent on what your worn helmet's CIT resolves to.

Examples:

Hopefully this helps!

mrmelon54 commented 1 year ago

What mod are you using for CIT? I don't really want to support Optifine with Fabric but if I make a Forge version of my mod in the future I guess I should at least try supporting it.

mattyalanestock commented 1 year ago

CIT Resewn: https://www.curseforge.com/minecraft/mc-mods/cit-resewn

mrmelon54 commented 1 year ago

Note to self: maybe copy armored elytra display name to chestplate in this part of the code? https://github.com/MrMelon54/armored-elytra-fabric/blob/d1939d9c6d44e238fcc474d24df788da6e3d5aab/src/main/java/xyz/mrmelon54/ArmoredElytra/items/VanillaTweaksArmoredElytraItem.java#L74

might be better here https://github.com/MrMelon54/armored-elytra-fabric/blob/d1939d9c6d44e238fcc474d24df788da6e3d5aab/src/main/java/xyz/mrmelon54/ArmoredElytra/mixin/MixinArmorFeatureRenderer.java#L52

mrmelon54 commented 1 year ago

image CIT Resewn appears to work in the 1.20 release, coming soon.

mrmelon54 commented 1 year ago

This is fixed in the new architectury version... https://github.com/MrMelon54/armored_elytra