Pim16aap2 armored elytra support

mrmelon54 / armored-elytra-fabric

Shows the elytra and armor when using the armored elytra datapack

12 stars 5 forks source link

Pim16aap2 armored elytra support #5

Closed bonn2 closed 3 years ago

bonn2 commented 3 years ago

This would add support for ArmoredElytras created with pim16aap2's spigot plugin

mrmelon54 commented 3 years ago

I'll take a look at this later

mrmelon54 commented 3 years ago

Golden and chainmail armour don't display correctly I'm assuming you just got those two muddled? Also I'm going to assume coloured leather support is impossible due to the way the data is stored (or not stored hence why there is no support for it).

mrmelon54 commented 3 years ago

Let me know when you are done making changes and I'll review the PR again

bonn2 commented 3 years ago

Color has the support built in for when the plugin updates. (I Built this in conjunction with it's author, so it should start working when that update is released) Golden and Chainmail are displaying correctly on my side so I'm not sure what is happening there

bonn2 commented 3 years ago

Here is the copy of armoredelytra that I was testing with ArmoredElytra-testbuild.zip

bonn2 commented 3 years ago

Hmm seems they are swapped due to a discrepancy between 2.4.14 of AE and the latest 3.0dev series on github

mrmelon54 commented 3 years ago

The test build you provided doesn't even work for me (testing on paper 1.16.5)

bonn2 commented 3 years ago

did you unzip it? Github doesn't let you upload .jars

mrmelon54 commented 3 years ago

It is detected by the server (aka it displays in /plugins) but putting a chestplate and elytra in an anvil doesn't do anything?

bonn2 commented 3 years ago

oh the 3.0 series also changes the default craft block to the smithing table. Toggle-able in config ofc, but that is probably it

mrmelon54 commented 3 years ago

Golden and chainmail armour still appear swapped but everything else (including coloured leather) appears to work fine

bonn2 commented 3 years ago

are those made new in that version? The issue is that the plugin stores a diff value in the items than it should

bonn2 commented 3 years ago

wait, hmm This wasn't happening last night lol

mrmelon54 commented 3 years ago

I am using the latest version of the code on your branch and I am using the test build for the plugin that you provided

mrmelon54 commented 3 years ago

You can probably just swap the values in the switch case for armor_tier_level

bonn2 commented 3 years ago

yeah that will fix it, I am just impressed I missed that. Since I know for a fact that I tested that at some point and it worked lol

bonn2 commented 3 years ago

Also turns out, no 2.4.14 of AE doesn't have an issue I did somehow just get them flipped

bonn2 commented 3 years ago

mrmelon54 commented 3 years ago

I can confirm this does work as intended

mrmelon54 commented 3 years ago

Is the new version of the spigot plugin going to be called 3.0?

bonn2 commented 3 years ago

Yes

mrmelon54 commented 3 years ago

Curseforge release for v1.0.8 is awaiting approval