search

mrmiguez / pymods

process MODS records from Python
https://pypi.python.org/pypi/pymods
MIT License
17 stars 0 forks source link

Pass up @valueURI for subject/name #2

Closed mrmiguez closed 7 years ago

mrmiguez commented 7 years ago

Should valueURI's from subject/elem@valueURI pass up to subject@valueURI when there isn't one there?

Example:

<subject>
  <name authority="lcnaf" 
              authorityURI="http://id.loc.gov/authorities/names" 
              type="personal" 
              valueURI="http://id.loc.gov/authorities/names/n79056767">
    <namePart type="date">1877-1956</namePart>
    <namePart type="given">Alben William</namePart>
    <namePart type="family">Barkley</namePart>
  </name>
</subject>

returns:

{ children: [ { type="name", valueURI="http://id.loc.gov/authorities/names/n79056767", ... }, ... ], ...}

when it might be more useful to return:

{ valueURI="http://id.loc.gov/authorities/names/n79056767", children= [...], ... }

mrmiguez commented 7 years ago

This was fixed sometime b/t v1 & v2.