Closed dice4321 closed 8 years ago
@diceman112 This actually happens because of KC3Kai's subtitles, as they sometimes cover up the images used to match during the sub switch routine. The above update should keep it from crashing, even with subtitles enabled. Unfortunately the subtitles can still cover the portion of the screen used to ID whether or not the ship under repair is a submarine. These false negatives will make kancolle-auto wait for that ship's repair to finish, instead of switching it out. Minor inconvenience, but if constant combat is important to you then the workaround would be to disable KC3's subtitles.
@mrmin123 wow! Thanks for looking into my problem and directing me to the solution! maybe I'll try out KCV since I was using KC3 for the subtitles mostly
@diceman112 No problem! Honestly, I think with the above changes the chance of kancolle-auto crashing even with KC3's subtitles will be very very rare... The only thing I can't guarantee is the submarine switch subroutine properly recognizing that the ship in question is a submarine. You can also just disable KC3's subtitles when you're just letting the bot go. Just throwing out some ideas.
If you are submitting a feature request or a non-bug report, please feel free to delete this template. Also feel free to delete sections of this template you do not find relevant when submitting a bug report. Thanks!
Environment details
Issue
Is the issue consistent (can be reproduced consistently) or is it transient (only happens sometimes)? Please check one of the boxes:
This has happened to me multiple times now, sometimes it happens and sometimes it doesnt. Kancolle-auto would just stop working when its trying to switch subs, I think it skips a click somewhere in here and cant find the switch ship button.
Console log (if applicable)
Relevant config snippet (if applicable)