search

mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

adding Event1-1 NodeSelection pictures #246

Closed nekoma0 closed 7 years ago

nekoma0 commented 7 years ago

am i doing this correctly?

mrmin123 commented 7 years ago

Hi @nekoma0 , thanks for the PR. The images are correct, but they should be named _node_E-1-B.png and _node_E-1-C.png, to be consistent with previous builds.

It'll also be nice to make the PR to the pre-existing/on-going branch for the ticket item that involves adding 2016 Fall support, which is branch 243_2016_fall. You can change this by editing this PR and then choosing the merge target to 243_2016_fall (I can do this myself, so if you just want to update your PR with the above changes that'd be fine). There will probably be a merge conflict with _node_E-1-C.png as I already generated one but I can figure that out.

Thanks again!

nekoma0 commented 7 years ago

thanks, i'll try to remake a repo, and do the following changes, i kinda messed up and there's too many commitment record in my own repo. because was trying to rename those pictures, but couldn't find anyway, end up removing the pictures and adding them back with the renamed. then i figured out i should just remove the report and fork a new one. i'll close this.

at the same time, i am currently downloading github desktop, is the web github has some limitations?