search

mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

Adding SSVs to sub switching #303

Closed mrmin123 closed 7 years ago

mrmin123 commented 7 years ago

Continuing the work started by @waicool20 in #291. Will review fix for #288 here as well.

mrmin123 commented 7 years ago

@waicool20 note that I renamed the _kai suffixes to -kai

waicool20 commented 7 years ago

Need to revise the ship type check for sub switching since SSVs don't have the stats that fleetcomp_ship_stats_submarine.png currently has, so the script ends up not switching them out.

I think using the ship class kanji would be a better way of distinguishing ships, you could probably also forego going into the stats menu, unless you need the higher res image checking. Could save some time this way.

mrmin123 commented 7 years ago

@waicool20 Using the kanji was an approach I entertained when I initially created the sub switch module, but is something I ultimately moved away from due to two reasons:

  1. A lot more images that I would have to manually maintain
  2. Sub identification time actually has a worse worst-case performance

Point 1 is a bit moot now, ever since the EnabledSubs option introduction, which ended up requiring generation of individual assets for every sub anyway, but Point 2 still stands. With 15 SS and SSVs in the game the worst case results in kancolle-auto taking 15 seconds to identify a sub (and that's with the recent default Sikuli wait time optimization... otherwise it would have taken 45 seconds).

I'll definitely give this more thought but the current method might still be the fastest and most efficient generic implementation. I should note that submarines, including SSVs, have a default stat of AA and ASW of 0, which is what kancolle-auto checks for. For the moment I would advise that your SSVs only be equipped w/ equipment that do not alter these two stats.

If you have use-case situations where you need SSVs in your fleet, and they have to be equipped with AA/ASW equipment, and they need to be automatically sub-switched, let me know what that situation is and I may be convinced to consider this harder, but I've never encountered this myself.

waicool20 commented 7 years ago

I guess I'll equip all my subs with only torps then, and take out any seaplane bombers a sub might have before starting a session.