3/17 patches

[waicool20]

Patch released today will require several updates on the script:

• Expeditions UI has changed greatly:
  • Flagship, levels and daihatsu/drum indicators have been added.
  • Expedition start button has changed
• Fleet presets increased to maximum of 10, so that needs to be implemented. Probably not gonna affect the script but the save/delete button were moved farther away from each other. Save button removed in the expand menu.

Edit: Forgot to mention sortie UI has also changed, they added level indicators which may or may not interfere with the current reading of the ship girls statuses

[stackhanovets]

Well yeah. There is a bunch of new buttons. Android interface is updated too, so there is no fun with Bluestacks/FreeBSD. Good luck @mrmin123 !

[AppleBoi86]

Some image changes in today's update.

sortie_combat.png http://i.imgur.com/RxoRQuP.png

sortie_top_combat.png http://i.imgur.com/pLEav08.png

combat.png (in combat folder) http://i.imgur.com/CtYRYb4.png

combat_start.png (in combat folder) http://i.imgur.com/36XhdcY.png

b.png (in quest folder) http://i.imgur.com/jRbNZFV.png

ensei_start.png (in exped folder) http://i.imgur.com/IQL90TD.png

All the changes I noticed. No problem on expedition part.

[mrmin123]

I quickly threw up a WIP branch with some of the updated assets before heading out to work: 340_patch

Expeditions, PvP, and Quests, are working I believe. Sorties should work but I'm a bit concerned about the new 'Lv.' indicator that might affect fatigue and damage-state identification... Will finalize later.

edit: fleet comp switcher might be broken due to new button placements? Unknown.

[waicool20]

Cool and just before I went to bed. I'll test this overnight.

[mrmin123]

• Fleet comp switcher shouldn't be broken, judging by the code, but untested.
• No separate LBAS sortie button now?? Only tested by comparing the sortie button for 6-4... I could be wrong tho.
• Damage detection seems to be working despite the Lv marker. I only had a moderate and light damaged to test again, but they both hit 1.00 on the match. Critical damage and fatigue still untested.

[waicool20]

There are some problems with LBAS right now and a fix is coming hot soon, so there maybe furthur UI changes down the line. (Airplanes getting deleted for some reason)

And btw it would seem the script is having trouble dealing with ships under repair when going for a sortie, keeps on recovering... I'll test this furthur.

[waicool20]

Otoh fleet comp isn't broken but idk if you plan on expanding support to the new 10 limit.

[mrmin123]

OK, thanks for the heads up. I'll try testing sorties a bit later myself, too.

[mrmin123]

I think I ever only made it to support the first 4 or 5 presets in the fleet comp switcher lol... I didn't have any of the slots expanded at the time of implementation =_= I'll probably expand on that at a later date in a separate ticket..

[mrmin123]

Oh, combat with under-repair ships are broken because combat_start_disabled.png hasn't been updated... working on it now.

edit: fixed now in WIP branch

[waicool20]

Ok quest b.png also has to be updated since they changed the plane pretty much game-wide

[mrmin123]

b.png should already have been updated on the branch with this:

Or does this image not work? I've not tested combat quests yet.

[waicool20]

Oh my bad, was looking at the wrong branch. The script seems to working great now :)

[etcet54]

It seems the expedition still have issues. After checking expedition status before sending the fleet, the script is automatically loop recovering and start all over again

[Bararun]

Thanks for the quick update even if it's just a WIP.

[mrmin123]

@stackhanovets good to know! Good news is that I've been running the sortie module for the last few hours and things seem stable.

@etcet54 Are you on the 340_patch WIP branch? Your script is failing to find ensei_start.png, which was changed in the last Kantai Collection update. master currently does not support this, although I will be updating it shortly.

@Bararun no problem! Changes are going into master shortly.

[mrmin123]

After some fumbling with PRs and releases, master has been updated. Leaving this open for a bit in case I missed anything.

[Bararun]

Old 420 patch seemed to work quite well but the new master you released is seemingly looping continously and never launches expedition 6, which is the first one I have set.

[etcet54]

@mrmin123 yes I was using 340_patch WIP. Will check the latest master update again, thanks a lot

[R-Jimenez]

Definitely seems to be something wrong with the fleet comp switching, or at least within the PvP module. Seems to go to the comp screen but unable to switch.

[mrmin123]

@Bararun @etcet54 sorry for getting back so late but I can't reproduce expedition 6 not starting. Latest master ran fine all night.

@R-Jimenez Fleet comp switcher is independent of PvP, and PvP has been running fine for the last day for me, so I'm guessing something wrong with the fleet comp switcher module. I'll try to debug today.

[etcet54]

@mrmin123 I have tested for a day and can confirm expedition works perfectly now. I didn't experience expedition 6 not starting, so can't really speak for that one.

Thanks a lot

[stackhanovets]

In my case, the 6th expedition has been set properly even on 02bbe98 ver.

[waicool20]

I'd say that increasing the sleep modifier might help with all these problems, at least that's what I do. Since there hasn't been much change script code wise, I don't think it's a bug within the script.

[AppleBoi86]

What do I need to change to make the click box smaller?
Since the sortie/expe button has been changed to be smaller. It will now click outside the target area and fail to start the expedition.

[mrmin123]

@AppleBoi86 just updating the image asset should do it. kancolle-auto clicks anywhere within the match itself.

Also, regarding most other issues (excluding maybe the fleet comp switcher, since I haven't tested that yet), what @waicool20 said is correct. The game did not change much, nor did the script, and it's stable for a lot of people. Incidental/sporadic issues can probably be addressed by restarting or increasing the SleepModifier in the config.

[stackhanovets]

@AppleBoi86 , I don't realize what do you mean by "targeting issue", but I have performed some resizing tricks during events (e.g. banner changes after last kills etc) like: -> That worked fine in all cases, I haven't noticed clicks outside the template.

[R-Jimenez]

@mrmin123 Yeah, the PvP works fine. The exercises are properly executed, and handed off to the other modules. But the issue is that the fleet switcher isn't switching to the PvP fleet comp, so my training/victories are in mortal danger. D:

Also, don't know if it's been documented, but I the submarine switcher seems to be a bit too zealous. I have my list specified as ss, i-19-kai, i-26-kai, i-58-kai, but I-13/I-14 are still being pulled off the bench. Is this because of what we had to do before with stripping planes and any AA/ASW stat boosters off of them? Is a sub without those stats considered an SS when the group flag is used in the list like above?

[mrmin123]

I13 and i14 should not be switched in with that configuration. If they are, it is a bug. Stats were only relevant for identifying if the ship to be switched out was a sub, not for identifying whether or not the ship to be replaced with was the sub. If you didn't have I13 or i14 in your fleet to begin with and theyre getting pulled in, that is a bug.

On Mar 19, 2017 6:31 PM, "R-Jimenez" notifications@github.com wrote:

@mrmin123 https://github.com/mrmin123 Yeah, the PvP works fine. The exercises are properly executed, and handed off to the other modules. But the issue is that the fleet switcher isn't switching to the PvP fleet comp, so my training/victories are in mortal danger. D:

Also, don't know if it's been documented, but I the submarine switcher seems to be a bit too zealous. I have my list specified as ss, i-19-kai, i-26-kai, i-58-kai, but I-13/I-14 are still being pulled off the bench. Is this because of what we had to do before with stripping planes and any AA/ASW stat boosters off of them? Is a sub without those stats considered an SS when the group flag is used in the list like above?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mrmin123/kancolle-auto/issues/340#issuecomment-287664349, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIF0lPDCo7kofAMgeMtpbv0N2uxeAvAks5rndb5gaJpZM4MgV0- .

[NanjoW]

Another thing that I've noticed is that Moral isn't tracked correctly on Married Ships due to the ring blocking the indicator.

[R-Jimenez]

@mrmin123 Understood. Would you like me to make separate issues for these bugs?

[mrmin123]

@R-Jimenez yes please