mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

Fleetcomp cycler #350

Closed waicool20 closed 7 years ago

waicool20 commented 7 years ago

Currently working on a fleetcomp cycler to cycle fleetcomps while sortieing, useful for maps like 4-3 where fatigue might be important, implementing feature as stated in #86

Don't merge yet as it's still WIP

waicool20 commented 7 years ago

I've added some conditionals, which should let the script act almost like before except that if FleetComps has more than 1 element it will cycle through them. Otherwise it'll ignore its value to save time and assume the current fleet is the desired one.

waicool20 commented 7 years ago

Created a branch at https://github.com/waicool20/KAGA/tree/fleetcomps for support for the new config type

mrmin123 commented 7 years ago

Thanks for picking this up!

FYI I'll be focusing on another personal project the next few days, and after that I have some other personal events going on which will occupy most of my time for another week or two, so I might not be around to review code and PRs. Until then, feel free to open a ticket on the issue tracker and reference this branch so people can test it.

waicool20 commented 7 years ago

Ahh sure btw as for the other request in #86 `` automate sortie to multiple maps with multiple saved fleetcomps```, I think a possible solution is to delegate it to KAGA, I think I can create a "scheduler" where it executes multiple profiles in succession, that way people can configure it to sortie to different maps.

waicool20 commented 7 years ago

Ok I've added input validation for the fleetcomps, it should error out if any value specified is not an integer between 1-10

waicool20 commented 7 years ago

Shouldn't switch if the fleets are the same now in case that combat fleetcomp only specifies 1 fleet, otherwise it always attempt to switch fleetcomps

mrmin123 commented 7 years ago

Thanks for the update. As an FYI, I am going to defer feature additions until post-event.