search

mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

FleetComp Cycler (Needs testers) #351

Closed waicool20 closed 7 years ago

waicool20 commented 7 years ago

Kancolle Auto

I have picked up a feature request as requested in #86, pull request #350 , going on forth, admirals should be able to specify a list of fleet comps for the Combat module to cycle through.

Expected behavior is that the script rotate fleet comps specified by FleetComps if more than one fleet comp is specified otherwise it should be identical to previous iterations of the script.

NOTE: FleetComp has been renamed to FleetComps in the config

For testers of the script download here: https://github.com/waicool20/kancolle-auto/archive/fleetcomp_cycler.zip

KAGA

I have also updated KAGA to support the new configuration in this branch: https://github.com/waicool20/KAGA/tree/fleetcomps

NOTE: Existing profiles FleetComps will be set to nothing when first read due to the rename above. It's advised to configure it again and then save.

waicool20 commented 7 years ago

Download to a compiled KAGA snapshot of commit ad8af276f2ee64a670b0b1ffa1514cc739ae322d :

KAGA_FleetCompCycler.zip

phantasia15 commented 7 years ago

Tested this for a while.

It does swapping fleets as intended. Although there was a problem when using together with SubmarineSwitch module.

If one of the fleets contains a submarine being repaired and SubmarineSwitch is enabled than that fleet's sortie is canceled until the submarine is out of the dock. Basically, it happens like this: Switch to fleet 1 > go to sortie screen > check and find out a ship being repaired > go to dock and get some invalid timer, go to composition screen and swap out the submarine under repair > wait till next sortie > Switch to fleet 2 > ..... > Switch to fleet 1 and the same things happen again until the submarine is out of the dock.

waicool20 commented 7 years ago

Fleet 2 is sortieing normally right? Well I'm not sure what a good solution to this should be. As it is, I prefer it that way, as it'll continue to sortie fleet 2 until fleet 1 sub is out of the docks then fleet 1 is ready. The script does not track/cache per fleet ships/status so its pretty hard to determine when one of the fleet preset ships are ready.

phantasia15 commented 7 years ago

Yeah, Fleet 2 is sortieing normally.

I think FleetComp Cycler is fine as it is. However, SubmarineSwitch module needs to be modified a bit so that they can work together. When a damaged/under repair sub is found before sortieing, instead of swapping the subs then ending the current cycle and waiting for next iteration, SubmarineSwitch should swap out the sub and continue with the sortie.

waicool20 commented 7 years ago

Seems like a good solution overall even not considering the fleet comp cycler module, would be nice to have I guess, I'll look into it.

mrmin123 commented 7 years ago

PR is merged!