mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

Add/revise assets for 2017 Spring Event #363

Closed mrmin123 closed 7 years ago

mrmin123 commented 7 years ago

Apparently there's another event starting?

Same business as usual... provide uncompressed PNG screenshots here, or, if you'd like to generate the assets yourself, please follow the asset generation guide.

Work-in-progress branch is here: 363_2017_spring_event

waicool20 commented 7 years ago

Event has started! Good luck to all the front liners.

waicool20 commented 7 years ago

image Node H is a selection node

mrmin123 commented 7 years ago

363_2017_spring_event branch has been added; has E-1 assets and asset to sortie to E-2 (no node selection assets yet)

@waicool20 unfortunately those ripped asset map images aren't the most useful because the nodes don't reflect the nodes in-game. Also doesn't show the node selection text bubble from the ship if it happens to run into the asset area.

waicool20 commented 7 years ago

hmm too bad then, i only plan on starting after all the fleet comps come out so I haven't had the chance to take a proper screenshot.

AppleBoi86 commented 7 years ago

Here are some E-2 assets I used to farm Kunashiri. Ran about 20 times until I got her, no issue.

Node select. i.imgur.com/yxXcupY.png

LBAS - T node i.imgur.com/Z75oX4f.png i.imgur.com/roK7qoI.png

waicool20 commented 7 years ago

image E1 Node selects, I didn't go J so sadly no image for that :/

mrmin123 commented 7 years ago

@waicool20 node selection images for E1 are already in the WIP branch (I ended up going to J lol), but thanks.

I won't get a chance to sortie to E-2 until late weekend at best, but @AppleBoi86 has provided some (all?) images already. These are not in the WIP branch yet, but hopefully by tonight they will be.

waicool20 commented 7 years ago

image image Just cleared E1H, @AppleBoi86 only provided the T node, heres the R node images for the transport phase

R-Jimenez commented 7 years ago

I came back from a work binge right as the event started, but managed to frontline it thanks to this lovely script keeping my resource game strong. I'm not entirely sure exactly what is needed, but I can provide maps and node selections for farming as requested; I've got all the maps cleared up. Cheers, mates. o7

waicool20 commented 7 years ago

@mrmin123 I feel like the event system can be improved somewhat, I think instead of using images, maybe creating a flat file that contains the event + node coordinates would be a better solution perhaps? Using coordinates removes the need to create 2 separate image for each node. In code it would just be reading in the coordinates and constructing a new Region object then clicking randomly in it. That way users can just copy paste the flat file instead of having to clone/pull a separate branch each event which not all people know how to do.

Possible format, X and Y relative to kc_region

<Quarter> <Year>
------
<Map><Node> <X> <Y> <W> <H>           // W and H can probably be ignored

eg.

Spring 2017
-----
E1R 90 110 70 70                  // Not actual X Y

Since I don't think the events will be overlapping all to much, I think the event Quarter/Year can be inferred from the current date, so for Node Select/LBAS config they can just specify

Group1Nodes = E1B, E1K, E2D, E2G         // Any nodes not matching the sortieing map is ignored

Put all the above in something like event.txt in the root folder, bonus points for KAGA also has an easier time parsing stuff (although the current implementation is fine also)

mrmin123 commented 7 years ago

@waicool20 I'm not sure I agree with that being a better solution.

In the context of node selects, how would you know that node selection is available? You'd have to randomly click on where the node(s) are between every combat node and compass spin (these also have variable spin times). This is also very unforgiving if there is any lag or delay. Also, how do you account for nodes where there are no compass spins and combat node?

This is a slightly better idea for LBAS because there's no variation in timing and the node assignments always happen at the same point in time within a sortie, but it then comes down to who maintains and supplies these coordinates? Images are relatively easy because either 1) I reach that map node and update assets, or 2) a benevolent user provides their screenshots, which I use to easily update assets. The turnaround time is certainly a bit longer, but it's also the exact amount of effort I'm willing to put in for something that has to be updated multiple times every three months.

waicool20 commented 7 years ago

@mrmin123 For node selects it is possible to wait for this image to appear: image

Maintaining the coordinates shouldn't be any different than before, some person will still need to provide a full game map screenshot. Common image tools like gimp already give you the x and y of the crop box.

Node appearance can vary a lot like in the case of LBAS selection, was hoping such a system would cut down on the images needed. Also I presume it would be more convenient for the end user.

mrmin123 commented 7 years ago

Good point regarding the speech bubble, but I just don't see the need to implement and switch over. The current implementation works fine. It might be inconvenient for the non-git-comfortable user but I'm not exactly trying to cater to their convenience needs.

waicool20 commented 7 years ago

That's true, well still worth pointing out in case you give the script an unlikely overhaul ¯\_(ツ)_/¯

waicool20 commented 7 years ago

So I havn't used kc-auto for any event automation yet, but after sortieing to E2 several times, I've noticed that the sortie start button is more "compressed" than usual because of the new LBAS indicator below. Don't know if it will affect matching or not.

image

mrmin123 commented 7 years ago

Yea that'll probably need to get updated, thanks for pointing that out.

On Sat, May 6, 2017 at 11:45 AM, waicool20 notifications@github.com wrote:

So I havn't used kc-auto for any event automation yet, but after sortieing to E2 several times, I've noticed that the sortie start button is more "compressed" than usual because of the new LBAS indicator below. Don't know if it will affect matching or not.

[image: image] https://cloud.githubusercontent.com/assets/5538666/25775070/331afa22-32cf-11e7-9896-ec5bceb64e5a.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mrmin123/kancolle-auto/issues/363#issuecomment-299658703, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIF0n0DnUJdVOoFrYxfEzfCvpxn-GWFks5r3L_RgaJpZM4NNuIA .

R-Jimenez commented 7 years ago

So if you don't have any active LBAS the icon remains as it was before, which means the search will have to look for both unless the similarity is close enough to pick up both. I have been running E2 for testing successfully but have not used LBAS.

R-Jimenez commented 7 years ago

I went and tested it, and sorties do break with LBAS enabled.

twisting2017 commented 7 years ago

Hope those help: panel1 panel2 e3lbas e3choice

mrmin123 commented 7 years ago

@AppleBoi86 @waicool20 @twisting2017 thanks you all. I've added E-2 ~ E-3 assets, as well as sortie-start support for E4 and E5, to the WIP branch. I've also updated the LBAS sortie start button (thanks @R-Jimenez for confirming it broken).

NanjoW commented 7 years ago

@waicool20 iirc the grid lines are static on every map in the game. Technically we can just estimate everything right at the beginning as soon as the event starts and the maps get data mined. You can create a static value for how much a grid is worth i.e. 10px or something and then just count the grids out. like A node on E3 is .5 across and 3 down. so roughly 5px out and 30px down. This can almost be done pragmatically. and then just dynamically create the flat files every event. with no user input. and then just mark the ones that are selectable as we get the info.

I do agree with @mrmin123 that the current implementation is perfectly functional and I really don't think it has a problem, but it would be nice to have it be able to parse the event data by itself and have all the info right away at the start of the event. I might try to build an implementation like that as a PoC and I'll post it if I do. I'll have to dig through the combat file to figure out the best way to implement it.

perryhuynh commented 7 years ago

_event_panel_1-3.png is currently the same asset as _event_panel_1-2.png

Here's a screenshot of the map 3 panel

frosty5689 commented 7 years ago

I'm having issues with LBAS selection not working for E2 R node. Anyone else experiencing the same?

mrmin123 commented 7 years ago

I just realized that the E-2 R node LBAS assets are only valid for the first sortie. I'll resolve this later tonight.

I will also update the E-3 panel as an included fix.

frosty5689 commented 7 years ago

Yeah. I'm trying to use LBAS for transport phase, the R node appears as a boss node.

e2-transport-r-node

mrmin123 commented 7 years ago

@frosty5689 if you're still sortieing to E2, could you take screenshots of the R node with one LBAS marker on it (before you put the second LBAS assignment on it)?

frosty5689 commented 7 years ago

@mrmin123 here you go.

I also took one without any selection, the one i attached earlier was taken from host machine of the VM, so the colors are off.

2017-05-10-190225_1680x1050_scrot 2017-05-10-190249_1680x1050_scrot

mrmin123 commented 7 years ago

@perryhuynh @frosty5689 branch has been updated with updated assets!

perryhuynh commented 7 years ago

Some E-5 Stuff (note: these will only work after you've sortied through the map once to the respective boss nodes)

Asset Image
_node_lbas_E-5-R_1
_node_lbas_E-5-R_2
_node_lbas_E-5-T_1
_node_lbas_E-5-T_2
_node_E-5-N

Missing node_E-5-D and sorry not cropped

mrmin123 commented 7 years ago

Thanks @perryhuynh , assets have been updated to add E-5 stuff.

Is that pretty much all of it? I'm considering merging to master now.

mrmin123 commented 7 years ago

Some might be missing but the core assets are in, so I've merged. I'll leave this open for a bit in case people want to supply/request additional assets.

frosty5689 commented 7 years ago

Here's LBAS assets for E-3 V node 2017-05-13-145308_1680x1050_scrot 2017-05-13-145311_1680x1050_scrot

mrmin123 commented 7 years ago

@frosty5689 could you provide screencaps with less of the game cropped out? See here to see about how much space is required.

frosty5689 commented 7 years ago

Does these work? I tried to leave 25px on each side (the right side can't because of TP bar)

_node_lbas-e-3-v_1 _node_lbas-e-3-v_2

mrmin123 commented 7 years ago

@frosty5689 yep, thanks! Added those as well as additional assets for E-5 to master.