search

mrmin123 / kancolle-auto

Kantai Collection (Kancolle) bot/automation tool - DEPERECATED - see kcauto-kai:
https://github.com/mrmin123/kcauto-kai
54 stars 22 forks source link

Submarine Bucket Use Toggle #364

Closed R-Jimenez closed 7 years ago

R-Jimenez commented 7 years ago

Feature outlined in #354.

mrmin123 commented 7 years ago

Thanks for the update. As an FYI, I am going to defer feature additions until post-event. I'd also like to look into the CLASS_SIMILARITY value a bit more before merge. Depending on the needed values the approach to the constant might have to change.

R-Jimenez commented 7 years ago

Roger that. o7 I feel like having a high CLASS_SIMILARITY is worth it, since only one or two classes are tricky enough to warrant a lower setting for accurate searching. Why not just have two tiers? CLASS_SIMILARITY and CLASS_SIMILARITY_LOW/CLASS_SIMILARITY_SSV?

mrmin123 commented 7 years ago

@R-Jimenez please separate out the 0.8 and 0.65 thresholds to additional globals at top of combat.py as CLASS_SIMILARITY_SS and CLASS_SIMILARITY_SSV and reference those in the code. It'll help during refactor so I can keep track of globals.

R-Jimenez commented 7 years ago

Changes pushed.

mrmin123 commented 7 years ago

@R-Jimenez It looks like some unrelated changes got pushed with your latest commits. Please revert those, merge in master, and repush the branch.

R-Jimenez commented 7 years ago

Sorry about that. Git had some confusion with the branches and pulled files I thought were not committed. Should be much cleaner now