This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of xo.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Removes the promise/no-promise-in-callback and promise/no-callback-in-promise rules. They were more annoying than useful. You usually have to deal with a lot of non-Promise APIs, so I had to disable it too many times. Some APIs will also never be Promise, like events and streams. 2253852
With Integrationsfirst-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.
Screencast Try it today. Free for private repositories during beta.
Hello lovely humans,
xo just published its new version 0.18.1.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of xo. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
GitHub Release
Removes the
promise/no-promise-in-callbackandpromise/no-callback-in-promiserules. They were more annoying than useful. You usually have to deal with a lot of non-Promise APIs, so I had to disable it too many times. Some APIs will also never be Promise, like events and streams. 2253852The new version differs by 24 commits .
d82bdea0.18.12253852Removeno-promise-in-callbackandpromise/no-callback-in-promiserules5209ec8Minor tweakd5d18f4Minor code style tweaks (#196)27c65a2xo ~> 0.18.0bf6260c0.18.034ab00bFix some lint issuesf87990aBump dependenciesf8e1e3dHandle negative gitignore patterns correctly (#195)a0ae248Ignore directories when receiving an empty extension (#194)da188e5Don't trigger duplication errors for Flow type imports (#193)cb63c5fAdd tip on how to use XO with monorepos0d88cdeAdd--stdin-filenameoption29a5263Remove theimport/no-dynamic-requirerulea469eb6Link to the Vim pluginThere are 24 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.