search

mrmonat / nova-translatable

Nova Field for spatie/laravel-translatable package.
81 stars 26 forks source link

Add event bus to sync locale between nova-translatable field instances #15

Open cdupoiron opened 6 years ago

mrmonat commented 6 years ago

Hi, thanks for your pull request, i like the idea, but I think we could use the global Nova Event Bus, instead of using our own? (what do you think?) I saw a parameter dontEmit, where would this be set? I think we should make it configurable in config/translatable.php and add an extra method to override it something linke ->emitChanges(true/false)

cdupoiron commented 6 years ago

Hi, OK, great idea, is there a doc about the global Nova Event Bus?

OK to make it configurable

mrmonat commented 6 years ago

Yes, you can find the documentation for the Event Bus here: https://nova.laravel.com/docs/1.0/customization/frontend.html#javascript

cdupoiron commented 6 years ago

OK, thank you