mrmrinal / pe

0 stars 0 forks source link

No support for duplicates #5

Closed mrmrinal closed 2 years ago

mrmrinal commented 3 years ago

All three shows called pikachu can be added and there is no functionality to check if the same word with slightly different casing has been added

image.png

nus-pe-bot commented 2 years ago

Team's Response

duplicate of #4427

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Half-baked Duplicate detection

For the add command, input validation for the name is too strict.

Assume the user adds this anime, add n/Shingeki Hi e/0 , and then wants forgets about if for sometime and re-watches more episodes and tries to enter as a new record, add n/Shingeki Hi e/5. This time, a new anime is added as there's an extra whitespace between the 2 words, while it obviously is referring the same anime.

I think it's better if this is allowed, or a helpful output given before adding a possible duplicate into the app

image.png

Also, duplicate detection of anime based on its name is not case-insensitive, allowing me to add anime 15 and 17 as follows but they 17 should be caught as a duplicate.

image.png


[original: nus-cs2103-AY2122S1/pe-interim#4400] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

From AniList Devs:

:<

Best Regards!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]