Closed marionzualo closed 8 years ago
Wow - this is a really well put together PR for something so simple! Much appreciated!
@mrmrs Cool. Happy to help. Let me know if you need help with that v2 branch. Do you have a tasklist? I have some time to go through stuff.
@marionzualo - I don't have a well spec'd out task list. I don't have strong opinions on what the perfect version of this. But you can definitely take a stab at it. I think ideally it would be:
Do you have any thoughts?
@mrmrs I had the following things in mind:
Gemfile
so the Ruby dependencies are locked (e.g. the Jekyll version)imagemin-cli
so images can be minimized as part of npm run build
As for the markup I was fine with how it was since it is just a base template. But I can change it if you have anything specific in mind.
I might also probably come up with some ideas when I start using nkd
to develop a couple of sites but for now those are the only ideas I have.
What does this PR do?
Fixes some issues with the Jekyll configuration yml file that resulted in not being able to run
jekyll serve
in the V2 branch.The "@" character can't be the first character in a yml configuration value. So I replaced @ with ". This invalid character resulted in not being able to run "jekyll serve" on jekyll 3.2.0.
I also changed the footer links so they work correctly with the values provided in the configuration file.
How should this be manually tested?
› gem install jekyll -v 3.2.0
npm instal
npm start
and confirm everything renders correctlyAny background context you want to provide?
I wanted to install the base project but I ran into some errors around sass (reported in https://github.com/mrmrs/nkd/issues/22) so I decided to help with releasing a postcss build. I found this issue while building the https://github.com/mrmrs/nkd/tree/v2 branch on which @mrmrs as been working on.