search

mrmrs / nkd

Template for jekyll project with postcss and browser-sync
http://mrmrs.io/nkd
229 stars 26 forks source link

Should the links in _head.html be absolute? #3

Open drewish opened 11 years ago

drewish commented 11 years ago

I was trying this out and noticed a bunch of 404s for the favicon and i.css files. I think the links in _head.html should either be absolute, e.g. href="/favicon.ico" or include the liquid tag for the site root: href="{{ site.url }}/favicon.ico".

mrmrs commented 11 years ago

That should probably be a step in the build process but I haven't gotten that far, I welcome any help via pull requests :)

This works locally for me - but both of your solutions break my flow. I do a lot of device testing and the ip of my machine sometimes changes, so managing the ip address as a url in the config is a little bit of a pain for me personally. It does most likely break the url on post pages, but for my concerns - I only want to check how the icon renders, so I can do it off of the home page just fine.

As most people probably don't have my workflow I'm comfortable making the dynamic liquid tag the default.
I'll add in some comments that indicate how to do device testing. Thanks for bringing this up.

drewish commented 11 years ago

Yeah it seems like the current way would work fine a for site totally in the root directory, but as soon as you have a page in a subdirectory it falls down.

On Aug 17, 2013, at 1:20, Adam Morse notifications@github.com wrote:

That should probably be a step in the build process but I haven't gotten that far, I welcome any help via pull requests :)

This works locally for me - but both of your solutions break my flow. I do a lot of device testing and the ip of my machine sometimes changes, so managing the ip address as a url in the config is a little bit of a pain for me personally. It does most likely break the url on post pages, but for my concerns - I only want to check how the icon renders, so I can do it off of the home page just fine.

As most people probably don't have my workflow I'm comfortable making the dynamic liquid tag the default.

I'll add in some comments that indicate how to do device testing. Thanks for bringing this up.

— Reply to this email directly or view it on GitHub.