mrniko / netty-socketio

Socket.IO server implemented on Java. Realtime java framework
Apache License 2.0
6.82k stars 1.65k forks source link

On AckManager.scheduleTimeout, potentially calls onTimeout twice #103

Closed msmyers closed 10 years ago

msmyers commented 10 years ago

We resolved this issue by calling removeCallback() and calling onTimeout() on that callback instead of the passed in one. This will be null if it has already been cancelled. Otherwise it would call .onTimeout() on a callback that was cancelled or already timed out (potentially).

We had it happen and traced the issue back. Edited our branch appropriately.

https://github.com/Zipwhip/netty-socketio/commit/12aa05292370fcf6377679b880fbffda6748fc3d

mrniko commented 10 years ago

fixed, thanks for patch