Unescaped \n, \r, " in packet caused "parse error" on client in jsonp mode

mrniko / netty-socketio

Socket.IO server implemented on Java. Realtime java framework

Apache License 2.0

6.82k stars 1.65k forks source link

Unescaped \n, \r, " in packet caused "parse error" on client in jsonp mode #205

Closed alim-akbashev closed 9 years ago

mrniko commented 9 years ago

your fix has not been worked with "\n" in string

alim-akbashev commented 9 years ago

Weird, works in our project. I'll recheck in demo project. On Feb 5, 2015 10:33 AM, "Nikita Koksharov" notifications@github.com wrote:

your fix has not been worked with "\n" in string

— Reply to this email directly or view it on GitHub https://github.com/mrniko/netty-socketio/issues/205#issuecomment-73011271 .

alim-akbashev commented 9 years ago

yep, found it. in fact it's another half of the issue - NPE on server-side during parse POST of new message. Need to fix PacketDecoder in same manner as PacketEncoder. In progress. new fix will be committed soon :)

alim-akbashev commented 9 years ago

oh, sorry, had not noticed that you've already fixed. do you want me to continue the work on this issue? i have another solution, imho, little bit more optimal.

mrniko commented 9 years ago

some optimizations, thanks for your help

alim-akbashev commented 9 years ago