search

mrnocreativity / postcss-critical-split

A PostCSS plugin that takes existing CSS files and splits out the annotated critical styles into a seperate file.
MIT License
89 stars 6 forks source link

Plugin breaks with gulp-postcss 7.0 #7

Open micahjon opened 7 years ago

micahjon commented 7 years ago

Today I ran yarn upgrade and noticed that my critical CSS files got a lot smaller (they were missing a bunch of critical rule-sets).

In my bash shell, I also noticed two errors from Gulp: Node#before is deprecated. Use Node#raws.before Node#moveAfter was deprecated. Use Node#after.

I played around with reverting dependency versions and was able to isolate the gulp-postcss 6.4 to 7.0 upgrade as the source of this bug.

I'm guessing this is due to gulp-postcss 7.0 dropping support for Node 0.12 or using a new major version of PostCSS (6.0), but I'm out of my depth when it comes to Node. Let me know if you're unable to replicate this bug--I'd be happy to keep digging for answers on my Mac.

Also, thanks a million for your hard work on this plugin. We use it in production at Goshen College.

mrnocreativity commented 6 years ago

Thanks for pointing this out. I'm currently not able to work on my open-source projects so feel free to provide a pull request. I'd be willing to merge it as soon as possible :)