search

mrob95 / Breathe

High-level API for creating dragonfly grammars
GNU Lesser General Public License v3.0
13 stars 8 forks source link

fixed flaky test ( order dependency from test #9

Closed Auzel closed 3 years ago

Auzel commented 3 years ago

Tests should be able to be ran independently. My proposed change removes the order dependency in the execution of test_manual_context_noccr test. Thus, this test would no longer fail because of an independent (isolated) run or a run in a different execution order.

mrob95 commented 3 years ago

Looks good to me, thanks! You're right that the tests should all be atomic and not serially dependent.

Also noticed that the CI tests don't seem to be running on PRs from forks, that is hopefully also fixed now.