search

mrob95 / mathfly-talon

Talon scripts for dictating mathematics into editors like LyX and Scientific Notebook 5.5.
https://mathfly.org
7 stars 9 forks source link

Add autoformatters #3

Open pokey opened 1 year ago

pokey commented 1 year ago

Any objection to using black / ruff / talonfmt like we're doing in the other talon repos? Happy to file a PR

mrob95 commented 1 year ago

Go for it 👍

Also more generally if you think it would make sense to move this repo into an organisation or merge it into knausj then I'm absolutely open to that. It's kind of in maintenance mode for me now since I'm no longer at university and using it every day.

pokey commented 1 year ago

Great; will do. I think fine to have it under your repo for now, similar to how we've kept knausj repo under knausj85. Interesting idea to merge into knausj, tho. Will file an issue to discuss

pokey commented 1 year ago

Would be great if you could install https://pre-commit.ci/ on this repo so that the autoformatters run automatically on PRs. Would also be good to require PRs so that we ensure the autoformatters run before hitting main branch. You can make an exception for yourself if you expect it to be too much of a hassle to be required to make PRs yourself

Alternately you could just add me as an admin if you don't feel like doing all that stuff yourself 😄

mrob95 commented 1 year ago

pre-commit should have access now. It looks like for personal repositories I can only make you a "collaborator" and I don't know how much permission that gives you to mess with project settings etc. I have added protection to master and required PRs

pokey commented 1 year ago

pre-commit should have access now.

Awesome thanks!

It looks like for personal repositories I can only make you a "collaborator" and I don't know how much permission that gives you to mess with project settings etc.

Ah yeah that's right; I believe that limitation on personal repos is one of the main reasons we've considered moving knausj to an org. No worries for now; I think you've taken care of all the stuff I'd need admin for in the short term

I have added protection to master and required PRs

Great!