mrocklin / dask-tutorial

BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

Tokens in Source Code #13

Open WillKoehrsen opened 1 year ago

WillKoehrsen commented 1 year ago

There are coiled tokens in plaintext in two of the notebooks (2-dataframes-at-scale and 3-uber-and-lyft). Although these tokens are expired, it would still be best practice to use environment variables that are not committed to the repo, especially in a tutorial that others may copy.

If you put COILED_TOKEN and COILED_ACCOUNT_NAME in a git-ignored .env file or a config file (~/.zshrc), you could use environment variables instead of the actual token and account name:

!coiled login --token $COILED_TOKEN --account $COILED_ACCOUNT_NAME

Thanks for creating the tutorials!