search

mrocklin / multipledispatch

Multiple dispatch
https://multiple-dispatch.readthedocs.io/en/latest/
Other
807 stars 71 forks source link

LICENSE not included #135

Open PaulKMueller opened 1 month ago

PaulKMueller commented 1 month ago

Currently the license is not being included in the conda-forge version of this package. Newer conda-forge packages require this.

This results in all future updates of the feedstock failing because the license file can not be found. For an example see https://github.com/conda-forge/multipledispatch-feedstock/pull/10.

image

It can probably be fixed by creating a MANIFEST.in in this repository with the following in it:

include LICENSE.txt

Afterwards the feedstock can be adapted to use this newly included license file.

I am happy to take over the fixing of the feedstock and already have a local version of the changes (probably) needed in this repository, but am not authorized to push a new branch.

What do you think? Including the license file in the distribution seems sensible to me and you probably also want the feedstock to remain maintainable.

mrocklin commented 1 month ago

You're welcome to put up a pull request with the change

PaulKMueller commented 1 month ago

I think the protection rules of this repo keep me from pushing the branch for the PR.

image
mrocklin commented 1 month ago

Most open source projects operate with forks on github. I recommend looking at contributor guidelines for some more common project, like pandas.

This repository is used in enough critical infrastructure that there's zero chance I'll grant commit rights to someone unless I know and trust them very deeply.