Dev/integration check

[MessuKilkain]

• Fix folding by not folding filtered lines
• Add setting to fold at the end of the line or between lines
• Add setting to display multi-lines log entry entirely after filter
• Fix travis build failure due to use of deprecated API
• Add setting to toggle case sensitivity in filter regexp
• Add toggle case sensitivity button in Filter-bar
• Add setting to display some lines before and after the filtered lines

I was trying to use the package for my Objective-C log, expected to get something as useful as the filter provided by AndroidStudio for Android logs. I got several issues to get what I wanted. First I wanted to fix the behaviour of folding to fit what I expected (and I guess should be).

PS : If the merge request contains too many things/features and you prefer to integrate them in an other way, I have one branch per feature so please, feel free to ask.

[mrodalgaard]

Hi @MessuKilkain, sorry for the very late reply on this. I have been out traveling.

First of all, great job! It is some great new features and looks very solid. I only have a few minor points with your implementation (see list below, just for reference), which I will solve myself after merging:

• Squash precedingFilteredExpansion and followingFilteredExpansion to one config.
• performTextFilter has grown to a monster of 52 lines (including two lines with +280 characters).
• Readme notes on new settings.
• Missing basic unit tests.
• I don't think I completely understand the useMultiLinesLogEntrySupport config. It seems to create some pretty random filters.

Again, great job and thank you.

[MessuKilkain]

Thank you for the answer. Here are some explanations on the modifications I made :

• I was using two different settings because in some cases, you want to see what is after your filter without seeing what is before and vice versa.
• useMultiLinesLogEntrySupport is expected to solve the issue of some log entry (for me it was iOS logs) as the following

2011-03-10 08:51:35.717 Logger[574:707] {
    ASLMessageID = 5294;
    Facility = "com.apple.console";
}

[mrodalgaard]

Ah, I see. Clever way of using the timestamp extraction. I have marked it as experimental, because I see too many cases it fails. That is also why I didn't include timestamp sorting in the first place, but kept the code if someday I had the time to improve on it further.

I have just published an update to the package.