mrodalgaard / language-log

Log file syntax highlighting in Atom
MIT License
42 stars 9 forks source link

Logformat changed for Android Marshmallow #24

Closed coffee-with-milk closed 7 years ago

coffee-with-milk commented 7 years ago

The output format of logcat has changed with Android Marshmallow. It would be great if this plugin supports the new output format.

# Example output on Marshmellow:
#    10-13 07:28:57.654  2814  2828 I TestRunner:   at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:101)
#    10-13 07:28:57.654  2814  2828 I TestRunner:   at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:87)
#    10-13 07:28:57.654  2814  2828 I TestRunner:   at org.junit.runners.Suite.<init>(Suite.java:81)
#    |                   |     |    | |           |
#    |                   |     |    | tag         message
#    |                   |     |    |
#    timestamp           x1    x2   tagtype

compare with the output of "Pre-Marshmallow":

# Example message:
#      I/System.out( 4630): Some message
#      | |           |      |
#      | tag         |      message
#      |             |
#      tagtype       owner

See https://github.com/JakeWharton/pidcat/issues/102 for some inspiration.

mrodalgaard commented 7 years ago

Looks pretty good to me. I might add the last parentheses, that indicates where the output was from. But that part was also present in the old format. Which syntaxes are you missing?

I did however see some issues with newest Atom version (1.13) which is fixed now!

screen shot 2017-01-15 at 20 48 26
coffee-with-milk commented 7 years ago

Thanks for looking into this issue. I was missing the first mentioned syntax, but it seems to be fixed by now. Don't know whether it was your commit or the atom changes. Thank you!