Open Lewiscowles1986 opened 3 years ago
😂 because of the CDN usage when deploying, the changes are not actually visible. https://youtu.be/WKKFbsL9vao
Merging #78 (f19cc50) into master (de63b80) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 239 242 +3
=========================================
+ Hits 239 242 +3
Flag | Coverage Δ | |
---|---|---|
unit | 100.00% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
lib/clear-suggestions.js | 100.00% <100.00%> (ø) |
|
lib/highlight.js | 100.00% <100.00%> (ø) |
|
lib/render.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update de63b80...f19cc50. Read the comment docs.
Hmm.. Says 100% coverage. Did I miss something the automated checkers missed?
Purpose (TL;DR)
To enable screen reader software and assistive ARIA aware technologies to announce each item as highlighted prior to selection. Fixes #77
Background (Problem in detail)
Detailed in #77
Solution
Uses additional ARIA attributes to announce choices prior to selection, differentiating from selection announcement. Supporting DOM changes. (likely "choice" constant will need to be configurable).
Other solutions considered
Please see ticket.
How to verify - mandatory
npm ci
npm run start
Contributor declaration
[x] I've read and followed the contributing document.
[x] The code I am submitting is mine to submit and is done so under the license of this repository.
[x] Where features have been changed, there are tests and documentation to accompany the entire contribution.
All tests remained passing as the behavior of these attributes is not owned by plete.
Documentation should not be necessary as this is a transparent change.
Please let me know. I expect the first-cut is an improvement, but may need further improvement.