feat!: Remove async/await and make conversions sync

mrodrig / json-2-csv

Convert JSON to CSV *or* CSV to JSON!

https://mrodrig.github.io/json-2-csv

MIT License

421 stars 58 forks source link

feat!: Remove async/await and make conversions sync #239

Closed Nokel81 closed 1 year ago

Nokel81 commented 1 year ago

There were no requirements within the code to have them async

Signed-off-by: Sebastian Malton sebastian@malton.name

Background Information

Fixes issue(s): #238
Proposed release version: 5.0.0

I have...

[x] added at least one test to verify the failure condition is fixed.
[x] verified the tests are passing.

Nokel81 commented 1 year ago

@mrodrig can we merge this and get 5.0.0 released?

coveralls commented 1 year ago

coverage: 97.872% (+0.08%) from 97.796% when pulling 71f7b5cc099250132725a573f7b5d401d313d77c on Nokel81:make-everything-sync into aafbbf0e2d29f317ac9fb1896d98b27166f8fb50 on mrodrig:main.

mrodrig commented 1 year ago

Hi @Nokel81, sorry for the delay in getting back to this. This PR looks great! I'll get this merged in and will update/create some documentation in preparation for releasing it in a 5.0.0 version. Hopefully I'll be able to have everything all set to publish it tonight.

Thanks again!