chore: change deprecated string method

[diegoreis42]

Background Information

• Fixes issue(s): No
• Proposed release version: 5.5.2

I have...

• [ ] added at least one test to verify the failure condition is fixed.
• [x] verified the tests are passing.

While reading the code, I found deprecated warnings. This is not a breaking change, but rather a precaution against potential errors. A clean project like this should not have trivial and annoying warnings.

[mrodrig]

Thanks for the PR @diegoreis42! I hadn't noticed the deprecation warnings recently, so that's a good catch.

It looks like the tests are failing currently for these changes, and I believe it's because the parameters for substr and substring are slightly different. MDN has some details about the differences here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring#the_difference_between_substring_and_substr

(Edit: Added a screenshot since the link to the specific section wasn't working)

If you're able to update the logic accordingly, I'd be happy to get this merged in and publish a new version with this update.

Thanks again!

[diegoreis42]

I'm sorry for the mistake; I only ran the tests for my first change 😅. All tests are now passing.

[coveralls]

coverage: 98.015%. remained the same when pulling fd1871f1c0214e9eb2ba370f9a793d95ac744d6b on diegoreis42:minor-fix into 84f088b944a0d26ea4ae7c082439162d9047150e on mrodrig:main.

[mrodrig]

Thanks @diegoreis42! I'll get this published in 5.5.3 now.