Signup Page - Githubissues

mrodz / receiptify

2 stars 0 forks source link

Open zeplar-exe opened 1 month ago

zeplar-exe commented 1 month ago

[x] Require input of an email and a password which meets some security threshold.
- I will delegate this to you
[x] Keep in mind: email/password also requires a code verification in the account creation auth flow.
- The account will exist regardless of whether they click the link or not, but the server-side account status will be "unverified"
[x] Keep in mind: Sign In AND Sign Up are the exact same function for SSO
[x] Link to Login Page.

zeplar-exe commented 1 month ago

Security threshold looks good to me for now. Only added one change to require a symbol.

In the future, we could use a library for password validation but for now it's unnecessary.

zeplar-exe commented 1 month ago

Will add the email account verification tomorrow with the warning/infobox on /profile.

mrodz commented 1 month ago

I added this regex to check the password:

/^(?=.*\d)(?=.*[A-Z])(?=.*[a-z])(?=.*[^\w\d\s:])([^\s]){6,}$/

I think this is ready for a PR. Let me know @zeplar-exe

zeplar-exe commented 1 month ago

Ah, I saw you went ahead and did the verify page. OK then. PR it is. @mrodz.