mronkko / ZoteroQuickLook

Implements QuickLook in Zotero
758 stars 82 forks source link

QuickLook shortcuts cmd + Y and spacebar do not work anymore #8

Open emelin opened 7 years ago

emelin commented 7 years ago

Would be nice, if this could be fixed. Thank you.

acsr commented 7 years ago

Can you be more specific on your setup!

We have here a similar but not exact the same issue.

We use ZoteroQuickLook 1.3.1.1-signed in Zotero Standalone 4.0.29.15 (and Firefox 49.0 and 48.0) on MacOSX 10.11.6 on both an older MacBookPro 17" and a more recent Retina 15"

Currently we only get a Quicklook Preview on natively imported MP3 and PDF files without and with surrounding container entry. No previews for website snapshots.

After Updating Firefox to 50.1.0 ZoteroQuickLook stops working there at all. In Zotero Standalone the preview keeps working limited on the plain pdf, mp3 files.

So far...

mronkko commented 6 years ago

Is this still a valid issue?

bwiernik commented 6 years ago

Spacebar works. I don’t think ZoteroQuickLook ever implemented the other Mac Quicklook shortcuts — Cmd-Y and Cmd-Opt-Y, so I think the original poster may have been mistaken.

mronkko commented 6 years ago

I remember implementing Cmd-y. What is Cmd-Opt-Y?

mronkko commented 6 years ago

Also, it used to be possible to do Cmd-Y from a citation in the word plugin, but this appears to be broken.

bwiernik commented 6 years ago

Cmd-Y doesn't currently work.

Cmd-Opt-Y opens quickook as a fullscreen slideshow.

bwiernik commented 6 years ago

https://support.apple.com/en-gb/HT201236

mronkko commented 6 years ago

I can see why the slideshow would be useful. I will see if that can be added easily. In the previous version of qlmanage, you could get a slideshow by clicking on the quicklook window.

bwiernik commented 6 years ago

While you're digging in the code, it might be nice to see if there is a way to get the qlmanage icon to not appear in the dock. It doesn't when using quicklook in Finder, but does for Zotero.

mronkko commented 6 years ago

Removing the icon and the [DEBUG] label from the window is doable, but would require some work. Quicklook is a framework and not an application in Mac OS, so it cannot be run directly. The proper way to use quicklook is to program and Mac program, which is then called from ZoteroQuickLook. Qlmanage is a tool that is mean for testing custom quicklook viewers and it is really a bit hack to use it the way zoteroquicklook does, but it works and was easy to implement.

I may implement this one day if I have too much free time (which has not been the case in the recent past.)

bwiernik commented 6 years ago

I see, no worries then. I imagine that by the time you have free time to devote to this that Zotero may have already transitioned to Electron, which has native quicklook support.