search

mrooding / gulp-protractor-cucumber-html-report

Generate html report from JSON file returned by cucumber-js json formatter
MIT License
12 stars 11 forks source link

Fixed multiple file buffer bug. #11

Closed Bill77 closed 8 years ago

Bill77 commented 8 years ago

Once opts.filename is set, all other files will use that same name. So the same file gets overwritten, but in order to support multiple .json files, had to add a temp variable that read the options object.

Also refactored the testing to support multiple files.

Relates to Issue 6.

nmeierpolys commented 8 years ago

I ran into the same issue. I just tested this commit with the fix locally and everything worked great.

Bill77 commented 8 years ago

Hi @mrooding,

Is there any updates on this? We would like to incorporated these changes into our system.

Thanks in advance, Bill

mrooding commented 8 years ago

@Bill77 Hi Bill, apologies for the silence. I'll come back to this this weekend once I've had the time to properly test this

Bill77 commented 8 years ago

@mrooding Hi Marc, thanks for getting back to me, sure no problem, let me know if I can be of any help for your testing. :)

Bill77 commented 8 years ago

@mrooding Hi Marc, was hoping for an update, thanks. :)

mrooding commented 8 years ago

Hi Bill, it took me a bit longer than expected but I've just merged this PR and released version 0.1.0

Let me know if you run into any issues and thanks for contributing!

Bill77 commented 8 years ago

@mrooding, Awesome, was able to pull the NPM package today. Thanks for the help, sorry I was a nag in trying to get this release. But this helps our me to close out a branch for our team. :)

Appreciate the help!