search

mroonga / docker

Dockerfile for Mroonga
13 stars 9 forks source link

Test script expects mroonga_libgroonga_version is same as mroonga_version #2

Closed yoku0825 closed 9 years ago

yoku0825 commented 9 years ago
yoku0825 commented 9 years ago
  1. Include Groonga's version into directory name.
    • ex) mysql5627_mroonga508_groonga508
    • I don't like this :(
  2. Make a file written couple of Groonga and Mroonga's version
    • YAML, JSON, ..
kou commented 9 years ago

Groonga and Mroonga will use the same version! For example, Mroonga 5.08 was released instead of 5.07.

yoku0825 commented 9 years ago

Groonga and Mroonga will use the same version!

I remember Mroonga 3.x series and 5.x series are exactly using the same version. But 4.x series were not. 4.03 was released at May 2014 and 4.04 was released at July 2014.

I have a plan to build Mroonga 4.10(the last release of 4.x series)'s image, should I plan it outside of this repository? (Hi.. Can you here me..? I'm talking your mind directly.. Is anyone who would like to use 4.x series..?)

kou commented 9 years ago

I have a plan to build Mroonga 4.10(the last release of 4.x series)'s image, should I plan it outside of this repository?

You can do it on this repository!

yoku0825 commented 9 years ago

I got it!!

Now we can write couples of MySQL version, Mroonga version, Groonga version by JSON like this. https://github.com/yoku0825/docker/blob/4834479e54915119dcdb23528450dd3268124ea3/test/version.json

Oops.. do you love YAML than JSON? :)

yoku0825 commented 9 years ago

Mroonga 4.10's dockerfile is ready. I can release its image after #5 merging.

kou commented 9 years ago

I prefer to YAML as format for writing by human. But it's not important.

yoku0825 commented 9 years ago

I prefer to YAML as format for writing by human.

Wow.. I'm surprised.. (Why I implement that by JSON is I think you like JSON more than YAML..)

But it's not important. Yep ;)

5 had been merged and I close this. Thank you!!

kou commented 9 years ago

Wow.. I'm surprised.. (Why I implement that by JSON is I think you like JSON more than YAML..)

Oh... I don't like the last "," isn't optional in JSON...