mroth / phoenix-showdown

:horse_racing: benchmark Sinatra-like web frameworks
705 stars 70 forks source link

Add play #6

Closed hunterboerner closed 9 years ago

mroth commented 9 years ago

Great! Can you please provide basic instructions for running the app and expected output sample from your machine so I know I'm doing it right when redoing the benchmarks here?

mroth commented 9 years ago

Some additional questions:

The appears to be a lot of files here, I'm not sure what's a.) auto generated boilerplate that is being used, b.) auto generated boilerplate that isn't being used, c.) actual handwritten app code since I'm not too familiar with Play/Scala.

I'd like to remove any unneeded boilerplate code so that when someone looks at this code versus the other samples they can more easily see what's the same and what's different.

On that note, an you please remove the boilerplate LICENSE and README files (or update the README to have instructions to run the app?

Since the tests aren't being used and appear to be boilerplate, can we remove those as well?

Will follow up with some line item notes on other specific things (I want to understand what's going on so I can update the writeup accordingly)

hunterboerner commented 9 years ago

Can you please provide basic instructions for running the app

activator start. Just wait for it to say that it's listening on port 9000.

I'll remove boilerplate stuff tomorrow.

mroth commented 9 years ago

FYI I am now working towards integrating this in PR #8, if you wish to follow along!

mroth commented 9 years ago

Now integrated in master via #8 (not sure why GitHub didn't automatically mark this as closed). Thanks again!