baronha
commented
2 days ago There is another problem when I build the example using expo, it seems to conflict with ExpoModuleCore and I can't resolve it.
Open baronha opened 2 days ago
baronha
commented
2 days ago There is another problem when I build the example using expo, it seems to conflict with ExpoModuleCore and I can't resolve it.
mrousavy
commented
1 day ago readonly isExportThumbnail?: boolean // --> It's normal if it's a string type.
Does it work if it's non-optional?
Please share the full build error in Xcode - there must be some kind of Swift error in the window where you took the screenshot. In your screenshot we can only see the build command invocation
mrousavy
commented
1 day ago it seems to conflict with
ExpoModuleCoreand I can't resolve it.
wdym?
baronha
commented
1 day ago readonly isExportThumbnail?: boolean // --> It's normal if it's a string type.
Does it work if it's non-optional?
Please share the full build error in Xcode - there must be some kind of Swift error in the window where you took the screenshot. In your screenshot we can only see the build command invocation
Showing Recent Messages
/Users/mac/Library/Developer/Xcode/DerivedData/MultipleImagePickerExample-cyaevycghzpzvkespefgrgrozofd/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/MultipleImagePicker.build/DerivedSources/MultipleImagePicker-Swift.h:5294:90: No member named 'bridge' in namespace 'margelo::nitro::imagepicker'Does this help you, Marc?
baronha
commented
1 day ago it seems to conflict with
ExpoModuleCoreand I can't resolve it.wdym?
I don't know but when I use the nitro module, Expo gives me an error like this. So I have to create another example for my library
baronha
commented
1 day ago And when I use HybridObject for the Result object in the callback function, more bridge errors appear.
My code:
import type { Options } from './Options.nitro'
export interface Results
extends HybridObject<{ ios: 'swift'; android: 'kotlin' }> {
readonly path: string
readonly fileName: string
readonly localIdentifier: string
readonly width: number
readonly height: number
readonly mime: string
readonly size: number
readonly bucketId?: number
readonly realPath?: string
readonly parentFolderName?: string
readonly creationDate?: string
}
export interface MultipleImagePicker
extends HybridObject<{ ios: 'swift'; android: 'kotlin' }> {
openPicker(options: Options, callback: (result: Results) => void): void
}My nitro.json:
{
"cxxNamespace": ["imagepicker"],
"ios": {
"iosModulename": "MultipleImagePicker"
},
"android": {
"androidNamespace": ["imagepicker"],
"androidCxxLibName": "MultipleImagePicker"
},
"autolinking": {
"MultipleImagePicker": {
"swift": "HybridMultipleImagePicker",
"kotlin": "MultipleImagePicker"
}
},
"ignorePaths": ["node_modules"]
}Ok yea we had the same issue after some testing internally - I'll fix this.
For now, I guess you can use a normal interface for Results, so not a HybridObject
mrousavy
commented
1 day ago The expo modules error is not really clear to me what caused it tbh.
mrousavy
commented
1 day ago Actually I think there might be multiple reasons for this:
baronha
commented
1 day ago Actually I think there might be multiple reasons for this:
- You need Xcode 16 (Swift 6) for Nitro
- You need react-native 75 for Nitro (Expo SDK 52 I think?)
Ah Not. I am using XCode 15.x Could this cause the above error?
hannojg
commented
1 hour ago @baronha definitely, XCode 15.x uses another Swift Compiler version, and you need to use the latest XCode
What's happening?
When I define a HybridObject that contains a boolean value, when I rebuild the library I get an error like this:
Reproduceable Code
Relevant log output
Device
Simulator iOS 15 Pro
Nitro Modules Version
0.11.0
Nitrogen Version
0.11.0
Can you reproduce this issue in the Nitro Example app here?
I didn't try (⚠️ your issue might get ignored & closed if you don't try this)
Additional information