mrousavy / nitro

🔥 Insanely fast native C++, Swift or Kotlin modules with a statically compiled binding layer to JSI
https://nitro.margelo.com
MIT License
561 stars 11 forks source link

mergeDebugNativeLibs failing in Old Arch on 0.76.1 #269

Open oblador opened 1 day ago

oblador commented 1 day ago

How were you trying to build the app?

Not sure if this is supposed to be supported or not, but when using nitro on 0.76.1 on a fresh, empty app the build fails on old arch while new arch works.

Full build logs

Execution failed for task ':app:mergeDebugNativeLibs'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.MergeNativeLibsTask$MergeNativeLibsTaskWorkAction
   > 2 files found with path 'lib/arm64-v8a/libreactnative.so' from inputs:
      - node_modules/react-native-nitro-modules/android/build/intermediates/library_jni/debug/copyDebugJniLibsProjectOnly/jni/arm64-v8a/libreactnative.so
      - react-android-0.76.1-debug/jni/arm64-v8a/libreactnative.so

Project dependencies

"dependencies": {
  "react-native": "^0.76.1",
  "react-native-nitro-modules": "^0.14.0",
}

Nitro Modules Version

0.14.0

Nitrogen Version

N/A

Target platforms

Android

Operating system

MacOS

Can you build the Nitro Modules Example app?

I didn't try (⚠️ your issue might get ignored & closed if you don't try this)

Additional information

mrousavy commented 1 day ago

Ah interesting - you might need a pickFirst in your build.gradle for that. Not sure if that's something Nitro Modules should do, or your app itself.