fix: Fix returning arrays of primitives not being properly sized in Java

mrousavy / nitro

🔥 Insanely fast native C++, Swift or Kotlin modules with a statically compiled binding layer to JSI

https://nitro.margelo.com

MIT License

642 stars 22 forks source link

fix: Fix returning arrays of primitives not being properly sized in Java #328

Closed mrousavy closed 1 week ago

mrousavy commented 1 week ago

When returning arrays of primitives (DoubleArray, BooleanArray, BigIntArray) from Java, we used getRegion from the primitive array to copy it directly into the std::vector::data().

The problem with that is that data() will not be properly sized in our case because we used std::vector::reserve(..) beforehand - instead of constructing the std::vector with a fixed size already.

This PR fixes that.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment