Add react-native-nitro-modules to peerDependencies in packages/template/package.json

jobpaardekooper commented 2 days ago

What's happening?

I am wondering if there is a reason why in the example/package.json file the react-native-nitro-modules is not added as a peer dependency. To me it seems from the nitro docs that library users will always need to install this package so might as well add it as a peer dependency. Or am I missing something?

I know it's a small thing, just curious if there is a reason not to do it.

Reproduceable Code

Relevant log output

Device

-

Nitro Modules Version

0.17.0

Nitrogen Version

0.17.0

Can you reproduce this issue in the Nitro Example app here?

Yes, I can reproduce the same issue in the Example app here

Additional information

[ ] I am using Expo
[X] I am using Nitrogen (nitro-codegen)
[X] I have read and followed the Troubleshooting Guide.
[ ] I created a reproduction PR to reproduce this issue here in the nitro repo. (See Contributing for more information)
[X] I searched for similar issues in this repository and found none.

mrousavy commented 2 days ago

The example/ is not an example library - it is an example app. The example librars is in packages/react-native-nitro-image.
The deps in the example app should be in dependencies, not devDependencies. Thanks for reminding me - I just fixed that.

jobpaardekooper commented 2 days ago

Sorry, I was looking at the wrong directory when writing the issue. I ment to refer to packages/template/package.json. There react-native-nitro-modules is not in the peerDependencies. And this is the template library that the documentations also suggests to copy to get started. For packages/react-native-nitro-image it is correctly listed in the peerDependencies but not for packages/template.

mrousavy commented 2 days ago

Ah you are correct!!

mrousavy / nitro