Fix types of createBlurhashFromImage

mrousavy / react-native-blurhash

🖼️ A library to show colorful blurry placeholders while your content loads.

https://blurha.sh

MIT License

1.98k stars 70 forks source link

Closed janicduplessis closed 5 months ago

janicduplessis commented 5 months ago

Those are supposed to be Ints and not Doubles, this fixes compilation with new arch enabled since codegen generates the types with Int.

mrousavy commented 5 months ago

Hey Mr. Duplessis - thanks for your PR my G!

CI fails unfortunately, looks like it still generated an abstract class that takes Doubles?

Screenshot 2024-06-24 at 09 25 27

janicduplessis commented 5 months ago

Maybe something changed in codegen, example is on 0.73 and my all where I tested new arch is 0.74. Are u ok to only support 0.74 for new arch?

mrousavy commented 5 months ago

yup that's fine! we upgrade the example then

janicduplessis commented 5 months ago

Good! I can update the example in a follow up

mrousavy commented 5 months ago

Is it okay if I wait with the release until the example works?

janicduplessis commented 5 months ago

Sure!