mrousavy / react-native-fast-tflite

🔥 High-performance TensorFlow Lite library for React Native with GPU acceleration
https://mrousavy.com
MIT License
723 stars 37 forks source link

Please release the updated library #88

Closed DZamataev closed 1 month ago

DZamataev commented 1 month ago

After merging this PR the library runs fine on iOS Simulator. But the library cannot be easily pulled in any react-native application package.json directly from main like so

    "react-native-fast-tflite": "mrousavy/react-native-fast-tflite#main",

because the tensorflow submodule appears empty in node_modules/react-native-fast-tflite/tensorflow.

Thats why I kindly ask @mrousavy to release the updated version of the library (1.3.1). For the users to be able to use it in their react-native projects without suffering the inability to run on iOS Simulator. Thank you in advance!

maintenance-hans[bot] commented 1 month ago

Guten Tag, Hans here. 🍻 Thanks for your input! It seems like there may be complications with pulling ze library directly from main. To help mrousavy with a proper fix, can you please provide logs from ze Xcode window or output from adb logcat? This information will greatly assist in diagnosing ze issue.

And if you want to ensure quicker support, consider sponsoring ze project for additional perks! Become a sponsor.

Note: If you think I made a mistake, please ping @mrousavy to take a look.

mrousavy commented 1 month ago

released 1.4.0 👍

Pingou commented 1 month ago

@mrousavy doesn't seem to compile now, any one else is having the same issue? At least it now works on iOS on the simulator...

https://github.com/mrousavy/react-native-fast-tflite/issues/91

mateoabrbt commented 1 month ago

Doesn't work on Android in 1.4.0 ! But it works on IOS 😭

mateoabrbt commented 1 month ago

Here is the error: node_modules/react-native-fast-tflite/android/../cpp/TensorflowPlugin.h:19:10: fatal error: 'tensorflow/lite/c/c_api.h' file not found

include <tensorflow/lite/c/c_api.h>

@mrousavy

manu13008 commented 1 month ago

Same issue here ! Anyone knows how to fix it without cloning all the tensorflow repository into the react native tflite fast module each time ?

Pingou commented 1 month ago

@manu13008 have you tried pointing to master in instead of the npm version? Ex of package.json: "react-native-fast-tflite": "git://github.com/mrousavy/react-native-fast-tflite#master",

manu13008 commented 1 month ago

@manu13008 have you tried pointing to master in instead of the npm version? Ex of package.json: "react-native-fast-tflite": "git://github.com/mrousavy/react-native-fast-tflite#master",

Going to give it a try ! Does that work for you ?

manu13008 commented 1 month ago

Okay. So nothing worked for me for Android :( I still get the same error as previous

lucksp commented 1 month ago

1.4.0 builds on iOS simulator, but I am seeing #91 errors in Android