Closed killserver closed 3 years ago
does this happen in debug builds as well, or only release?
That's so weird. I reverted the MMKV bump commits, so it has to be one of those changes:
Reverting one of those must fix the issue ๐คจ
Tried cleaning and rebuilding everything, does v1.2.2 work for you?
Doesn't work for me, getting this error:
And also checked the react-native-mmkv folder under node_modules, and there is no android folder:
huh wtf?? I wish I could just distribute it as source
huh wtf?? I wish I could just distribute it as source
tried creating the android folder manually and adding back the android.aar and build.gradle from 1.2.1 and it works! We're definitely getting there :)
I was trying same as fahad still same error
Okay so sorry guys I had to publish a few version before I finally got it right. Take a look at v1.2.5 and let me know if that builds for you now.
issue is still there man with 1.2.5 verision. typeError: _reactNativeMmkv.MMKV.set is not a function
On Mon, 9 Aug 2021 at 13:25, Marc Rousavy @.***> wrote:
Okay so sorry guys I had to publish a few version before I finally got it right. Take a look at v1.2.5 and let me know if that builds for you now.
โ You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mrousavy/react-native-mmkv/issues/111#issuecomment-895040311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM726VSN7DXAGSY2GFSK6EDT36GJBANCNFSM5BGN63MQ .
Builds fine for me, but still app crashes as soon as it launches:
08-09 17:48:48.119: I/MMKV(12715):
what the f? I'm getting "stack overflow" exceptions and I have no idea why. Any call to the jsiRuntime
apparently crashes. I have not touched anything there, so why the f does that crash?
Since you guys said that v1.1.6 works, I checked out at the commit where 1.1.6 was released and tried running the example app. Same crash. How? Why?
2021-08-10 10:12:16.168 1476-1520/com.example.reactnativemmkv I/HermesVM: HermesRuntimeImpl::call: Unable to call function: stack overflow
2021-08-10 10:12:16.169 1476-1520/com.example.reactnativemmkv A/libc: /buildbot/src/googleplex-android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:73: abort_message: assertion "terminating with uncaught exception of type facebook::jsi::JSINativeException: HermesRuntimeImpl::call: Unable to call function: stack overflow" failed
2021-08-10 10:12:16.169 1476-1520/com.example.reactnativemmkv A/libc: Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 1520 (create_react_co), pid 1476 (reactnativemmkv)
2021-08-10 10:12:16.213 1529-1529/? I/crash_dump32: obtaining output fd from tombstoned, type: kDebuggerdTombstone
2021-08-10 10:12:16.216 1909-1909/? I//system/bin/tombstoned: received crash request for pid 1520
2021-08-10 10:12:16.217 1529-1529/? I/crash_dump32: performing dump of process 1476 (target tid = 1520)
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: Build fingerprint: 'google/sdk_gphone_x86/generic_x86:10/QSR1.190920.001/5891938:user/release-keys'
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: Revision: '0'
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: ABI: 'x86'
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: Timestamp: 2021-08-10 10:12:16+0200
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: pid: 1476, tid: 1520, name: create_react_co >>> com.example.reactnativemmkv <<<
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: uid: 10136
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: Abort message: '/buildbot/src/googleplex-android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:73: abort_message: assertion "terminating with uncaught exception of type facebook::jsi::JSINativeException: HermesRuntimeImpl::call: Unable to call function: stack overflow" failed'
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: eax 00000000 ebx 000005c4 ecx 000005f0 edx 00000006
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: edi e7c4633e esi bf087710
2021-08-10 10:12:16.224 1529-1529/? A/DEBUG: ebp eab88ad0 esp bf0876b8 eip eab88ad9
2021-08-10 10:12:16.262 1783-1532/? E/ResolverController: No valid NAT64 prefix (101, <unspecified>/0)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: backtrace:
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #00 pc 00000ad9 [vdso] (__kernel_vsyscall+9)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #01 pc 00092328 /apex/com.android.runtime/lib/bionic/libc.so (syscall+40) (BuildId: 76290498408016ad14f4b98c3ab6c65c)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #02 pc 000ad651 /apex/com.android.runtime/lib/bionic/libc.so (abort+193) (BuildId: 76290498408016ad14f4b98c3ab6c65c)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #03 pc 000adb88 /apex/com.android.runtime/lib/bionic/libc.so (__assert2+56) (BuildId: 76290498408016ad14f4b98c3ab6c65c)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #04 pc 0009a874 /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libc++_shared.so (BuildId: e17c5af931f83c79fe858d7c19c030d4492104f4)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #05 pc 0009aace /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libc++_shared.so (BuildId: e17c5af931f83c79fe858d7c19c030d4492104f4)
2021-08-10 10:12:16.307 1529-1529/? A/DEBUG: #06 pc 000b2789 /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libc++_shared.so (BuildId: e17c5af931f83c79fe858d7c19c030d4492104f4)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #07 pc 000b1cbe /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libc++_shared.so (BuildId: e17c5af931f83c79fe858d7c19c030d4492104f4)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #08 pc 000b1c13 /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libc++_shared.so (__cxa_throw+115) (BuildId: e17c5af931f83c79fe858d7c19c030d4492104f4)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #09 pc 0001fef6 /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libhermes.so (facebook::hermes::HermesRuntimeImpl::call(facebook::jsi::Function const&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned int)+1078) (BuildId: df8072863d396d57901d03a3514af58b13e5c804)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #10 pc 0001854b /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libhermes-executor-common-debug.so (BuildId: feaf1ba9dd56d4aee4cd4cd150b3e084685387b6)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #11 pc 0004123e /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libmmkvnative.so (facebook::jsi::Function::createFromHostFunction(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, unsigned int, std::__ndk1::function<facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned int)>)+190) (BuildId: bebcb2f1c254db47c3fd84b1e5eb30b08c81d88f)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #12 pc 0004072b /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libmmkvnative.so (install(facebook::jsi::Runtime&)+171) (BuildId: bebcb2f1c254db47c3fd84b1e5eb30b08c81d88f)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #13 pc 00042260 /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/lib/x86/libmmkvnative.so (Java_com_reactnativemmkv_MmkvModule_nativeInstall+208) (BuildId: bebcb2f1c254db47c3fd84b1e5eb30b08c81d88f)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #14 pc 00144f67 /apex/com.android.runtime/lib/libart.so (art_quick_generic_jni_trampoline+71) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #15 pc 0013e9a2 /apex/com.android.runtime/lib/libart.so (art_quick_invoke_static_stub+418) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #16 pc 00149a7a /apex/com.android.runtime/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+298) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #17 pc 00332502 /apex/com.android.runtime/lib/libart.so (art::interpreter::ArtInterpreterToCompiledCodeBridge(art::Thread*, art::ArtMethod*, art::ShadowFrame*, unsigned short, art::JValue*)+386) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #18 pc 0032c19c /apex/com.android.runtime/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+988) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #19 pc 00684d03 /apex/com.android.runtime/lib/libart.so (MterpInvokeStatic+643) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #20 pc 001389a1 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_static+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #21 pc 000004f0 [anon:dalvik-classes3.dex extracted in memory from /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/base.apk!classes3.dex] (com.reactnativemmkv.MmkvModule.install+8)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #22 pc 002f8e0a /apex/com.android.runtime/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEbb.llvm.12194892193087984976+298) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #23 pc 002ffe19 /apex/com.android.runtime/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+217) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #24 pc 0032c17e /apex/com.android.runtime/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+958) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #25 pc 00684d03 /apex/com.android.runtime/lib/libart.so (MterpInvokeStatic+643) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #26 pc 001389a1 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_static+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.308 1529-1529/? A/DEBUG: #27 pc 00000462 [anon:dalvik-classes3.dex extracted in memory from /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/base.apk!classes3.dex] (com.reactnativemmkv.MmkvModulePackage.getJSIModules+54)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #28 pc 006837bc /apex/com.android.runtime/lib/libart.so (MterpInvokeInterface+1980) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #29 pc 00138a21 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_interface+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #30 pc 001c8f34 [anon:dalvik-classes.dex extracted in memory from /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/base.apk] (com.facebook.react.ReactInstanceManager.createReactContext+212)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #31 pc 006845ac /apex/com.android.runtime/lib/libart.so (MterpInvokeDirect+1324) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #32 pc 00138921 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_direct+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #33 pc 001c8e44 [anon:dalvik-classes.dex extracted in memory from /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/base.apk] (com.facebook.react.ReactInstanceManager.access$1100)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #34 pc 00684f6c /apex/com.android.runtime/lib/libart.so (MterpInvokeStatic+1260) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #35 pc 001389a1 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_static+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #36 pc 001c8560 [anon:dalvik-classes.dex extracted in memory from /data/app/com.example.reactnativemmkv-w1vmlG_EnMHIJtbuVzpBHw==/base.apk] (com.facebook.react.ReactInstanceManager$5.run+140)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #37 pc 006837bc /apex/com.android.runtime/lib/libart.so (MterpInvokeInterface+1980) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #38 pc 00138a21 /apex/com.android.runtime/lib/libart.so (mterp_op_invoke_interface+33) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #39 pc 000ea918 /apex/com.android.runtime/javalib/core-oj.jar (java.lang.Thread.run+8)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #40 pc 002f8e0a /apex/com.android.runtime/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEbb.llvm.12194892193087984976+298) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #41 pc 002ffcc5 /apex/com.android.runtime/lib/libart.so (art::interpreter::EnterInterpreterFromEntryPoint(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*)+181) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #42 pc 0066fbd9 /apex/com.android.runtime/lib/libart.so (artQuickToInterpreterBridge+1209) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #43 pc 0014503d /apex/com.android.runtime/lib/libart.so (art_quick_to_interpreter_bridge+77) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #44 pc 0013e7d2 /apex/com.android.runtime/lib/libart.so (art_quick_invoke_stub+338) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #45 pc 00149a69 /apex/com.android.runtime/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+281) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #46 pc 0055a513 /apex/com.android.runtime/lib/libart.so (art::(anonymous namespace)::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::(anonymous namespace)::ArgArray*, art::JValue*, char const*)+99) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #47 pc 0055b91a /apex/com.android.runtime/lib/libart.so (art::InvokeVirtualOrInterfaceWithJValues(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jmethodID*, jvalue const*)+474) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #48 pc 005aaa51 /apex/com.android.runtime/lib/libart.so (art::Thread::CreateCallback(void*)+1585) (BuildId: 895645e5113da057f27d9b2ec11eb3bf)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #49 pc 0011a8e5 /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+53) (BuildId: 76290498408016ad14f4b98c3ab6c65c)
2021-08-10 10:12:16.309 1529-1529/? A/DEBUG: #50 pc 000af6a7 /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+71) (BuildId: 76290498408016ad14f4b98c3ab6c65c)
2021-08-10 10:12:16.625 1909-1909/? E//system/bin/tombstoned: Tombstone written to: /data/tombstones/tombstone_06
FWIW, v1.1.6 works in a clean React Native project running the example app separately, without reanimated (I'm even using it in a work project with reanimated 1.x).
I was checking the commits after 1.1.6, one of them is the MMKV version bump (https://github.com/mrousavy/react-native-mmkv/commit/8a163397e98c61edaf5a2aed9804fe8cd50c7c46)
The changelog for that MMKV release mentions
Drop the support of armeabi arch. Due to some local build cache mistake, the last version (v1.2.9) of MMKV still has an unstripped armeabi arch inside. This is fixed.
Do you think it's something needed in react-native-mmkv ? If so, should it now build the lib for this architecture ?
I just released 1.3.0 (yay ๐), can you test if that works for you guys? It does work fine in the Example App (which is on RN 0.65.1)
While I already spent way too much of my free time on this issue to fix the crash for random people on the internet, I spent some more time on this yesterday and finally fixed it. Check out 1.3.1. ๐๐๐๐
If you appreciate my efforts, please consider buying me a coffee for my next late-night debug session: โค๏ธ GitHub sponsors
at startup - the bundle file is downloaded, but it still beats with an error as with version 1.2.0
while rolled back to version 1.1.6 - everything works there, but I would like to fix the problem anyway