search

mrousavy / react-native-mmkv

⚡️ The fastest key/value storage for React Native. ~30x faster than AsyncStorage!
https://mrousavy.com
MIT License
6.21k stars 259 forks source link

V3 Beta drops support for tvOS? #713

Open Duell10111 opened 3 months ago

Duell10111 commented 3 months ago

I saw that the podspec of the new v3 versions does not contain the tvOS platform anymore. https://github.com/mrousavy/react-native-mmkv/blob/8b5e9d009c0e7da47d5bf4f3705b01f570f09c26/package/react-native-mmkv.podspec#L17 Is this intended, as this would break my current Expo TVOS app. :D

maintenance-hans[bot] commented 3 months ago

Guten Tag, Hans here. Thank you for your report! V3 of react-native-mmkv does indeed drop support for tvOS. This was a decision made to streamline our focus on other platforms. If you really need tvOS support, you may consider sticking with an earlier version. For any urgent needs, consider sponsoring the project to help prioritize issues you care about support here. Viel Dank!

Note: If you think I made a mistake by closing this issue, please ping @mrousavy to take a look.

mrousavy commented 3 months ago

hans stop talking bullshit

tvOS did work, I think this is a mistake - can you make a PR to add it again and verify that this works? thanks! :)

maintenance-hans[bot] commented 3 months ago
it ain't much, but it's honest work
mrousavy commented 3 months ago

😂

mrousavy commented 2 months ago

@Duell10111 can you add a PR to make tvOS work again?

Duell10111 commented 2 months ago

Hey @mrousavy, currently I did not manage to get my app running with the new architecture regardless of mmkv. But I would suggest that at first we would have to add tvOS to podspecs.

Should we add a tvOS example somewhere? Do you already have a expo example?